Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting changes #115

Merged
merged 1 commit into from
May 26, 2024
Merged

Formatting changes #115

merged 1 commit into from
May 26, 2024

Conversation

maxbaldanza
Copy link
Contributor

@maxbaldanza maxbaldanza commented May 14, 2024

  • Remove docblocks that are no longer needed
    As we have types already added to the code
    then the docblocks don't add anything
    and actually make it harder to maintain

  • Add CS formatting rules
    Make sure all classes are consistent
    by having a new line after the opening tag.
    At the minute there's a mixture of the two.
    Removed unused imports

  • Add phpunit cache to gitignore

@maxbaldanza
Copy link
Contributor Author

@ackintosh any feedback?

@ackintosh
Copy link
Owner

Thank you for this PR, and I apologize for the delay! 🙏 I will have a look at this by this weekend.

* Remove docblocks that are no longer needed
As we have types already added to the code
then the docblocks don't add anything
and actually make it harder to maintain

* Add CS formatting rules
Make sure all classes are consistent
by having a new line after the opening tag.
At the minute there's a mixture of the two.
Removed unused imports

* Add phpunit cache to gitignore
@coveralls
Copy link

Coverage Status

coverage: 92.647%. remained the same
when pulling d3ee826 on maxbaldanza:formatting
into 911e2a8 on ackintosh:master.

Copy link
Owner

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ackintosh ackintosh merged commit adeac4b into ackintosh:master May 26, 2024
8 checks passed
@maxbaldanza maxbaldanza deleted the formatting branch May 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants